Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases screenshots for SIMMC-Furniture and API calls with better heuristics (SIMMC v1.2) #60

Closed
wants to merge 15 commits into from

Conversation

satwikkottur
Copy link
Contributor

No description provided.

satwikkottur and others added 13 commits March 8, 2021 15:21
Previous scene shouldn't depend on the action that follows it. Having looked at a few examples I think the call the get_carousel_state isn't needed.
SearchFurniture and NavigateCarousel actions result in views
of the carousel so don't need to include any previous in-focus
items. These are implicity removed by these two actions.
Making the "before" scenes more stable.
Leave out focus item when action is Search or Navigate
Raw actions are split by messages, not necissarily by when sharing
occurs. This is especially noticible when, say, a SpecifyInfo action is
inserted which doesn't often align with a share actions. Thus need to
take into acount when 'Share' occurs to determine the final scene as seen
by the user as the result of an one round.
Setting turn_carousel_state based on 'Share'
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 30, 2021
Copy link
Contributor

@skiingpacman skiingpacman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three comments (as mentioned offline), otherwise looks good.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mm_action_prediction/tools/extract_actions.py Outdated Show resolved Hide resolved
@satwikkottur satwikkottur marked this pull request as ready for review April 15, 2021 17:07
@facebook-github-bot
Copy link

@satwikkottur has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@satwikkottur merged this pull request in ca31013.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants